Skip to content

Compile with -fvisibility=hidden #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
casperisfine merged 3 commits into from
Mar 1, 2023
Merged

Compile with -fvisibility=hidden #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
594e4df
Compile with -fvisibility=hidden
byroot Mar 1, 2023
055ce21
Fix old-style-definition warning
byroot Mar 1, 2023
8ef92c9
Test against Ruby 3.2
byroot Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
'2.7',
'3.0',
'3.1',
'3.2',
]
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion ext/stack_frames/buffer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ static size_t buffer_memsize(const void *ptr)
return sizeof(buffer_t);
}

const rb_data_type_t buffer_data_type = {
static const rb_data_type_t buffer_data_type = {
"stack_frames_buffer",
{ buffer_mark, buffer_free, buffer_memsize, },
NULL, NULL, RUBY_TYPED_FREE_IMMEDIATELY
Expand Down
2 changes: 1 addition & 1 deletion ext/stack_frames/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require 'mkmf'
$CFLAGS << ' -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers'
$CFLAGS << ' -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden'
$CFLAGS << ' -Werror' if ENV['STACK_FRAMES_DEV']
create_makefile("stack_frames/stack_frames")
2 changes: 1 addition & 1 deletion ext/stack_frames/frame.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ static size_t frame_memsize(const void *ptr)
return sizeof(frame_t);
}

const rb_data_type_t frame_data_type = {
static const rb_data_type_t frame_data_type = {
"stack_frames_frame",
{ frame_mark, RUBY_DEFAULT_FREE, frame_memsize, },
NULL, NULL, RUBY_TYPED_FREE_IMMEDIATELY
Expand Down
2 changes: 1 addition & 1 deletion ext/stack_frames/stack_frames.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#include "frame.h"
#include "buffer.h"

void Init_stack_frames() {
RUBY_FUNC_EXPORTED void Init_stack_frames(void) {
VALUE mStackFrames = rb_define_module("StackFrames");
stack_buffer_define(mStackFrames);
stack_frame_define(mStackFrames);
Expand Down