Compile with -fvisibility=hidden #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: msgpack/msgpack-ruby#314 (comment) We experienced some weird segfault in `msgpack_buffer_mark` we couldn't explain. Until we noticed that the object being marked wasn't a `MessagePack::Buffer` but a `StackFrames::Buffer`. Both `msgpack` and `stackframes` were using the same symbol name to declare their respective buffer type, and the msgpack one was registered first. This is the counterpart of msgpack/msgpack-ruby#317 and generally speaking all gems should compile with `-fvisibility=hidden`.
dylanahsmith
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: msgpack/msgpack-ruby#314 (comment)
We experienced some weird segfault in
msgpack_buffer_markwe couldn't explain.Until we noticed that the object being marked wasn't a
MessagePack::Bufferbut aStackFrames::Buffer.Both
msgpackandstackframeswere using the same symbol name to declare their respective buffer type, and the msgpack one was registered first.This is the counterpart of msgpack/msgpack-ruby#317 and generally speaking all gems should compile with
-fvisibility=hidden.