Open
Conversation
Now that we require Ruby >= 3.1, we consistently have this method (as 3.1 includes Psych 4, and the method was introduced in 3.2.2).
We want to document: - Why we've enabled every cop we've enabled. - Why we've disabled cops the community would enable. - Why we've changed default configuration. We'll do this by appending `Reference` entries for the relevant cops. This sets up machinery for enforcing we've done that. As we re-triage cops, we'll update the test so it enforces `Reference`s across each department.
This adds references for configuration decided in "The Great Reset".
github-actions
bot
added
the
config change
rafaelfranca
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to document:
We'll do this by appending
Referenceentries for the relevant cops.This sets up machinery for enforcing we've done that. As we re-triage cops, we'll update the test so it enforces
References across each department.It also adds
References for the cops we've already configured in #687 & #693.TODO
References for cops configured in Enable cops in the Layout Department #688