Merged
Conversation
We aren't using it anymore. The main reason for it existing is that we had some rules that only made send for Rails applications. As we are resetting the rules, we don't know if we are going to need this file again.
We want to have frozen string literals by default.
Those are just linters trying to help with mistakes.
Those are all lints to catch mistakes.
They don't support Ruby 3.4.
github-actions
bot
added
the
config change
burke
approved these changes
Feb 13, 2025
Member
burke
left a comment
burke
left a comment
There was a problem hiding this comment.
I think this is right. We will definitely find we want to add some of them back but let's feel that pain first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change of direction for this project.
Before, we would restrict the expressiveness of Ruby for the sake of consistency and safety. This was causing Ruby programs that felt not really like Ruby.
Example of those rules were:
Now, this style guide, at least its cops, will focus on providing some consistency without making Ruby not look like Ruby. It will be more open to interpretation, and provide the freedom that Ruby always wanted to provide to their users.
It will also focus on catching mistakes. But not ones that require us to change how we write Ruby program.
In this PR:
We are disabling all cops with the exception of:
Drop support to Ruby 3.0
Later PRs will enable cops in other department, after careful review of their usefulness.