Skip to content

refactor: remove form-name from form title #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prafull-opensignlabs merged 1 commit into from
Aug 1, 2025
Merged

refactor: remove form-name from form title #1881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions apps/OpenSign/src/pages/Form.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,9 +680,7 @@ const Forms = (props) => {
</ModalUi>
<form onSubmit={handleSubmit}>
<div className="mb-[11px]">
<h1 className="text-[20px] font-semibold">
{t(`form-name.${props?.title}`)}
</h1>
<h1 className="text-[20px] font-semibold">{t(props?.title)}</h1>
{props.title === "Sign Yourself" && (
<div className="text-gray-500 text-xs mt-1">
{t("signyour-self-description")}
Expand Down
2 changes: 1 addition & 1 deletion apps/OpenSign/src/pages/Login.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ function Login() {
to="/forgetpassword"
className="text-[13px] op-link op-link-primary underline-offset-1 focus:outline-none ml-1"
>
{t("forgot-password")}
{t("forgot-password")}?
Copy link

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding punctuation outside the translation function is not ideal for internationalization. The question mark should be included within the translation key to allow proper localization for different languages that may have different punctuation conventions.

Suggested change
{t("forgot-password")}?
{t("forgot-password?")}

Copilot uses AI. Check for mistakes.
</NavLink>
</div>
</div>
Expand Down
8 changes: 4 additions & 4 deletions apps/OpenSign/src/pages/Opensigndrive.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,14 +712,14 @@ function Opensigndrive() {
onClick={() => navigate("/form/sHAnZphf69")}
>
<i className="fa-light fa-pen-nib mr-[5px]"></i>
{t("form-name.Sign Yourself")}
{t("Sign Yourself")}
</span>
<span
className="dropdown-item text-[10px] md:text-[13px]"
onClick={() => navigate("/form/8mZzFxbG1z")}
>
<i className="fa-light fa-file-signature mr-[5px]"></i>
{t("form-name.Request Signatures")}
{t("Request Signatures")}
</span>
</div>
</div>
Expand Down Expand Up @@ -840,14 +840,14 @@ function Opensigndrive() {
onClick={() => navigate("/form/sHAnZphf69")}
>
<i className="fa-light fa-pen-nib mr-[5px]"></i>
{t("form-name.Sign Yourself")}
{t("Sign Yourself")}
</span>
<span
className="dropdown-item text-[10px] md:text-[13px]"
onClick={() => navigate("/form/8mZzFxbG1z")}
>
<i className="fa-light fa-file-signature mr-[5px]"></i>
{t("form-name.Request Signatures")}
{t("Request Signatures")}
</span>
</div>
</div>
Expand Down