refactor: remove form-name from form title#1881
Merged
prafull-opensignlabs merged 1 commit intostagingfrom Aug 1, 2025
Merged
Conversation
refactor: remove form-name from form title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors internationalization (i18n) translation keys by removing the "form-name" namespace prefix from form titles and adds a question mark to the "forgot password" link.
- Simplified translation keys by removing "form-name." prefix from form titles
- Updated "forgot-password" link to include a question mark
- Made translation key structure more consistent across the application
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/OpenSign/src/pages/Opensigndrive.jsx | Removed "form-name." prefix from "Sign Yourself" and "Request Signatures" translation keys in dropdown menus |
| apps/OpenSign/src/pages/Login.jsx | Added question mark to "forgot-password" translation key |
| apps/OpenSign/src/pages/Form.jsx | Removed "form-name." prefix from form title translation key in the main form component |
| className="text-[13px] op-link op-link-primary underline-offset-1 focus:outline-none ml-1" | ||
| > | ||
| {t("forgot-password")} | ||
| {t("forgot-password")}? |
There was a problem hiding this comment.
Adding punctuation outside the translation function is not ideal for internationalization. The question mark should be included within the translation key to allow proper localization for different languages that may have different punctuation conventions.
Suggested change
| {t("forgot-password")}? | |
| {t("forgot-password?")} |
prafull-opensignlabs
changed the title
prafull-opensignlabs
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: remove form-name from form title