Merged
Conversation
revert: css of drive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prafull-opensignlabs
changed the title
prafull-opensignlabs
approved these changes
Jul 4, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR reverts recent CSS changes in the DriveBody component, restoring fixed container heights and replacing a grid layout with a flex-wrap layout for list items.
- Restores fixed square dimensions (
h-[100px]) and margin utilities for folder/PDF tiles. - Replaces the CSS grid in the PDF list view with a flex row wrap approach.
- Adjusts overall spacing to use explicit margins instead of the previous grid gap.
Comments suppressed due to low confidence (3)
apps/OpenSign/src/components/opensigndrive/DriveBody.jsx:408
- [nitpick] This Tailwind class string is repeated in multiple places; consider extracting these utilities into a single reusable class or component to reduce duplication and simplify future updates.
<div className="relative w-[100px] h-[100px] mx-2 my-3">
apps/OpenSign/src/components/opensigndrive/DriveBody.jsx:483
- [nitpick] Duplicate styling here matches the folder tile above; extracting this into a shared component or CSS module could improve consistency and reduce errors.
<div className="relative w-[100px] h-[100px] mx-2 my-3">
apps/OpenSign/src/components/opensigndrive/DriveBody.jsx:641
- [nitpick] Using manual margins here may lead to inconsistent gaps between items; consider leveraging Tailwind’s gap utilities (e.g., gap-x-3, gap-y-3) for clearer intent and responsive behavior.
<div className="flex flex-row flex-wrap items-center mt-1 pb-[20px] mx-[5px]">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert: css of drive