Implementing full support for OpenRing#113
Conversation
… turns out to be unstable
|
Visit the preview URL for this PR (updated for commit aa98746): https://open-earable-lib-web-example--pr113-open-ring-clean-4da0116t.web.app (expires Wed, 18 Mar 2026 14:54:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f6db4d9d00b851ad49af109fa949061904b3151 |
DennisMoschina
left a comment
There was a problem hiding this comment.
I tested it and it worked fine with the newest version of the app. The code looks also fine to me, though I did not check it in every detail. Off configurations are set properly and the related sensor config is also set correctly, making sure developers can configure sensors easily
|
@DennisMoschina I think the unit for the gyro is still off? Acc. seems fine now. Can you figure out what is a reasnoable unit for what the gyro produces and convert to dps? maybe currently it is in kdps? Also the temperature sensor has weird behavior, but it is "intended" as in we need a formula from the vendor i believe to get sth meaningful from the temp sensors. maybe we should change the temp unit to "raw" instead of °C. Otherwise, go ahead and merge :) |
…rs to match actual data
This is basically the same pull request as #110, but with only the parts about the open-ring support for a cleaner history. It was created by cherry picking the existing commits from open-ring that were important for the ring support