Implementing full support for OpenRing#110
Conversation
|
|
|
Visit the preview URL for this PR (updated for commit b1e3b8d): https://open-earable-lib-web-example--pr110-open-ring-pqv01yxi.web.app (expires Wed, 18 Mar 2026 10:54:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f6db4d9d00b851ad49af109fa949061904b3151 |
…enring-device Codex-generated pull request
| chartTitle: "Accelerometer", | ||
| shortChartTitle: "Acc.", | ||
| axisNames: ["X", "Y", "Z"], | ||
| axisUnits: ["g", "g", "g"], |
There was a problem hiding this comment.
This is certainly not in "g". Laying the Ring flat on the table results in 1000 on one axis and 0 on the others. So maybe it is "mg"?
| chartTitle: "Gyroscope", | ||
| shortChartTitle: "Gyr.", | ||
| axisNames: ["X", "Y", "Z"], | ||
| axisUnits: ["dps", "dps", "dps"], |
There was a problem hiding this comment.
This also does seem to not match the actual unit. A ring not in motion returns around 20 for some axes
| w.registerCapability<TimeSynchronizable>(timeSync); | ||
|
|
||
| unawaited( | ||
| _synchronizeTimeOnConnect( |
There was a problem hiding this comment.
Do we want to explicitly sync when connecting to a ring? Should the library or the app handle this? For OpenEarable the app checks if the device can synchronise the time and then synchronises. The library only provides this functionality but not call it.
There was a problem hiding this comment.
We need to (either automatically or manually) assign the 'off' value so that it can be used automatically. See SensorConfiguration.offValue
| axisNames: ["X", "Y", "Z"], | ||
| axisUnits: ["dps", "dps", "dps"], | ||
| sensorHandler: sensorHandler, | ||
| ), |
There was a problem hiding this comment.
Assign the related configurations to make it easier for developers to configure sensors
… turns out to be unstable
|
I created a new pull request #113 from a cleaned up branch with all the open ring changes while excluding everything that has nothing to do with the open-ring. I will now also created pull requests from separate branches that implement the other features. |
3 participants
No description provided.