Skip to content

Upgrade ktor to 3.4.0, kotlin to 2.3.0#23164

Merged
wing328 merged 4 commits intomasterfrom
luisvt-upgrade-ktor
Mar 7, 2026
Merged

Upgrade ktor to 3.4.0, kotlin to 2.3.0#23164
wing328 merged 4 commits intomasterfrom
luisvt-upgrade-ktor

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Mar 7, 2026

based on #23070 with minor fixes for the github workflow

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Upgrade Ktor to 3.4.0 and Kotlin to 2.3.0 across the Kotlin server generator and samples, migrating to the official Ktor Gradle plugin. CI workflows now use Gradle 8.11 and run Ktor samples in the JDK 17 job.

  • Dependencies

    • Ktor 3.4.0 and Kotlin 2.3.0 applied to templates and petstore samples (including modelMutable).
    • GitHub Actions updated to Gradle 8.11; Ktor/modelMutable samples moved to the JDK 17 workflow.
  • Migration

    • Switch to id("io.ktor.plugin") and remove the ktor-bom import.
    • Set application mainClass = "io.ktor.server.netty.EngineMain".

Written for commit 69577c6. Summary will update on new commits.

@wing328 wing328 changed the title Luisvt upgrade ktor Upgrade ktor to 3.4.0, kotlin to 2.3.0 Mar 7, 2026
@wing328 wing328 added this to the 7.21.0 milestone Mar 7, 2026
@wing328 wing328 marked this pull request as ready for review March 7, 2026 15:39
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

@wing328 wing328 merged commit f151c46 into master Mar 7, 2026
71 checks passed
@wing328 wing328 deleted the luisvt-upgrade-ktor branch March 7, 2026 15:46
@wing328 wing328 mentioned this pull request Mar 7, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants