Skip to content

[REQ] Upgrade ktor to 3.4.0#23070

Closed
luisvt wants to merge 1 commit intoOpenAPITools:masterfrom
luisvt:upgrade-ktor
Closed

[REQ] Upgrade ktor to 3.4.0#23070
luisvt wants to merge 1 commit intoOpenAPITools:masterfrom
luisvt:upgrade-ktor

Conversation

@luisvt
Copy link
Contributor

@luisvt luisvt commented Feb 27, 2026

  • Upgrade ktor to 3.4.0
  • Upgrade kotlin to 2.3.0

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l @dennisameling


Summary by cubic

Upgraded Kotlin server templates and samples to Ktor 3.4.0 and Kotlin 2.3.0, switching to the io.ktor Gradle plugin, removing the Ktor BOM, and updating build scripts (e.g., mainClass assignment).

  • Dependencies

    • Ktor 3.4.0 + io.ktor.plugin 3.4.0
    • Kotlin 2.3.0
    • Gradle wrapper 9.2.1
  • Migration

    • Regenerate Kotlin server projects to pick up new versions.
    • For existing projects, apply io.ktor.plugin, remove the Ktor BOM and the standalone application plugin, set application.mainClass as a string, and use Gradle ≥ 9.2.1.

Written for commit 688dfac. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

@wing328
Copy link
Member

wing328 commented Mar 3, 2026

Upgrade gralde-wrapper to 9.2.1

thanks for the PR. can you please separate that into another PR given that gradle 8.x is still supported?

@luisvt
Copy link
Contributor Author

luisvt commented Mar 3, 2026

Sure, I'll do it

@luisvt
Copy link
Contributor Author

luisvt commented Mar 6, 2026

@wing328 I just removed the change for upgrading gradle

@wing328
Copy link
Member

wing328 commented Mar 6, 2026

please update

to newer version to address the build failure

@luisvt
Copy link
Contributor Author

luisvt commented Mar 6, 2026

I just rebased to latest from master and force pushed

@wing328
Copy link
Member

wing328 commented Mar 7, 2026

merged via #23164 with minor changes in the workflow files

@wing328 wing328 closed this Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants