Allow concurrent non-blocking uploads#464
Merged
Conversation
Pull Request Test Coverage Report for Build 15966406027Details
💛 - Coveralls |
MarcelGeo
requested changes
Jun 12, 2025
Collaborator
There was a problem hiding this comment.
Looks good. Just questions and some minor tweaks.
-
In general, I do not understand, why is there this version number handling in push start.
-
Why are we guessing these changes? There was deal, that clients will divide transactions, no? It's porbably because we do not want to break old apis?
Collaborator
Author
|
move relevant validations into upload schema use upload schema only in push init while project file object is used for actual file manipulations remove version context and redundant dataclasses for upload schema
Refactor upload changes handling
MarcelGeo
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce blocking and non-blocking uploads while we allow for multiple concurrent non-blocking uploads to be created.
On DB level this constraint is achieved with partial index on blocking uploads.
Every upload creates subsequent project version so we do not specify which version should be created.
There is integrity check before creating project version in case of race conditions - clients should retry on 409 which would then finalize transaction with bumped project version.