Refactor upload changes handling#468
Merged
MarcelGeo merged 1 commit intoadd_non_blocking_pushfrom Jun 30, 2025
Merged
Conversation
Collaborator
varmar05
commented
Jun 17, 2025
- move relevant validations into upload schema
- use upload schema only in push init while project file object is used for actual file manipulations
- remove version context and redundant dataclasses for upload schema
move relevant validations into upload schema use upload schema only in push init while project file object is used for actual file manipulations remove version context and redundant dataclasses for upload schema
Pull Request Test Coverage Report for Build 15702878345Details
💛 - Coveralls |
MarcelGeo
reviewed
Jun 27, 2025
Collaborator
MarcelGeo
left a comment
There was a problem hiding this comment.
Looks nice, I am happy to get rid of version from changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.