Ignore the word vector during preprocessing for E3SM Makefile#200
Merged
mark-petersen merged 1 commit intoMPAS-Dev:developfrom Apr 8, 2019
Merged
Conversation
Contributor
Author
|
Reviewed by minxu, who notified us of this problem. He confirmed that this works: |
Contributor
Author
|
@jonbob could you do a visual inspection, and approve based on the resolution of E3SM-Project/E3SM#2725 (comment). Since this is the E3SM makefile, it is more relevant to us on the E3SM side. @matthewhoffman - any comment on this one? After merging this PR and #185 (memory leak index), we will merge the develop branch into all the cores, and update e3sm/develop. The E3SM PR will have all these makefile updates, but also all MPAS framework updates from the develop branch. |
mark-petersen
force-pushed
the
framework/cpp_ignore_vector
branch
from
70e1376 to
bbde9fd
Compare
Contributor
Author
|
Changed to caps TRUE format like other Makefile flags. |
mark-petersen
added a commit
that referenced
this pull request
Apr 8, 2019
Gnu CPP will treat "vector" as a macro on the PowerPC64 architecture. Add -Uvector to ignore. This was already done in the standard MPAS Makefile, but is now being added to the E3SM Makefile. fixes E3SM-Project/E3SM#2725
This was referenced Apr 9, 2019
Contributor
|
Just for future reference, we also added similar changes to the top-level Makefile in 7a66ba3 . |
mark-petersen
added a commit
that referenced
this pull request
Apr 10, 2019
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: #195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): #191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: #200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: #185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: #196, #197, #198, #199
mark-petersen
added a commit
that referenced
this pull request
Apr 10, 2019
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: #195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): #191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: #200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: #185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: #196, #197, #198, #199
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: MPAS-Dev#195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): MPAS-Dev#191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: MPAS-Dev#200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: MPAS-Dev#185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: MPAS-Dev#196, MPAS-Dev#197, MPAS-Dev#198, MPAS-Dev#199
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 11, 2021
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: MPAS-Dev#195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): MPAS-Dev#191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: MPAS-Dev#200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: MPAS-Dev#185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: MPAS-Dev#196, MPAS-Dev#197, MPAS-Dev#198, MPAS-Dev#199
caozd999
pushed a commit
to caozd999/MPAS-Model
that referenced
this pull request
Jan 14, 2021
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: MPAS-Dev#195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): MPAS-Dev#191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: MPAS-Dev#200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: MPAS-Dev#185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: MPAS-Dev#196, MPAS-Dev#197, MPAS-Dev#198, MPAS-Dev#199
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 16, 2021
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: MPAS-Dev#195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): MPAS-Dev#191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: MPAS-Dev#200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: MPAS-Dev#185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: MPAS-Dev#196, MPAS-Dev#197, MPAS-Dev#198, MPAS-Dev#199
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 19, 2021
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: MPAS-Dev#195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): MPAS-Dev#191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: MPAS-Dev#200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: MPAS-Dev#185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: MPAS-Dev#196, MPAS-Dev#197, MPAS-Dev#198, MPAS-Dev#199
willmayfield
pushed a commit
to willmayfield/MPAS-Model
that referenced
this pull request
Jan 14, 2026
* update derecho spack-stack to version 1.9.3 * use the official spack-stack location on derecho * Update version number --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gnu CPP will treat "vector" as a macro on the PowerPC64 architecture. Add -Uvector to ignore.
This was already done in the standard MPAS Makefile, but is now being added to the E3SM Makefile.
fixes E3SM-Project/E3SM#2725