E3SM and CESM are now using TRUE|FALSE for compile_threaded#191
Merged
mark-petersen merged 1 commit intoMPAS-Dev:developfrom Apr 3, 2019
Merged
Conversation
Contributor
|
At some point, would it also be worth renaming |
Contributor
Author
|
@mgduda , yes and yes. You may want to check with the CESM folks first. |
Contributor
Author
Contributor
|
Thanks @jgfouca |
Contributor
|
@jgfouca please change the target branch to MPAS-Dev:develop @mgduda and @matthewhoffman this is a framework PR, so I asked you to review. A quick glance is enough. |
Contributor
Author
|
@mark-petersen , done. |
matthewhoffman
approved these changes
Apr 3, 2019
mgduda
approved these changes
Apr 3, 2019
Contributor
mgduda
left a comment
mgduda
left a comment
There was a problem hiding this comment.
These changes look fine. We can pick up the issue of whether to rename Makefile.in.ACME to Makefile.in.E3SM, and whether to delete Makefile.in.CESM at a future time.
mark-petersen
added a commit
that referenced
this pull request
Apr 3, 2019
This change will need to be reflected in the MPAS submodule of E3SM as soon as possible.
mark-petersen
added a commit
that referenced
this pull request
Apr 10, 2019
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: #195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): #191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: #200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: #185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: #196, #197, #198, #199
mark-petersen
added a commit
that referenced
this pull request
Apr 10, 2019
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: #195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): #191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: #200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: #185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: #196, #197, #198, #199
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: MPAS-Dev#195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): MPAS-Dev#191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: MPAS-Dev#200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: MPAS-Dev#185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: MPAS-Dev#196, MPAS-Dev#197, MPAS-Dev#198, MPAS-Dev#199
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 11, 2021
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: MPAS-Dev#195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): MPAS-Dev#191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: MPAS-Dev#200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: MPAS-Dev#185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: MPAS-Dev#196, MPAS-Dev#197, MPAS-Dev#198, MPAS-Dev#199
caozd999
pushed a commit
to caozd999/MPAS-Model
that referenced
this pull request
Jan 14, 2021
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: MPAS-Dev#195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): MPAS-Dev#191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: MPAS-Dev#200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: MPAS-Dev#185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: MPAS-Dev#196, MPAS-Dev#197, MPAS-Dev#198, MPAS-Dev#199
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 16, 2021
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: MPAS-Dev#195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): MPAS-Dev#191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: MPAS-Dev#200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: MPAS-Dev#185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: MPAS-Dev#196, MPAS-Dev#197, MPAS-Dev#198, MPAS-Dev#199
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 19, 2021
Updating MPAS framework. This includes: - Rename Makefile.in.ACME to Makefile.in.E3SM: MPAS-Dev#195 - Change Makefile.in.E3SM to standard CESM formatting (TRUE in caps): MPAS-Dev#191 - Add -Uvector to Makefile.in.E3SM to ignore the word 'vector' in comments when using GEN_F90=TRUE: MPAS-Dev#200, fixes #2725 - Fix memory leak due to double allocate, only used by RK4 time stepping, does not change E3SM runs: MPAS-Dev#185 - Changes to atmosphere directories are not used by E3SM. - COMPASS testing updates, not used by E3SM, including python 3 updates. - Fix typos that cause warnings on some compilers: MPAS-Dev#196, MPAS-Dev#197, MPAS-Dev#198, MPAS-Dev#199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will need to be reflected in the MPAS submodule of E3SM as soon as possible.