Add a test to check if wrsamp can write more than 8 channels to format 516#451
Merged
tompollard merged 1 commit intomainfrom May 11, 2023
Merged
Add a test to check if wrsamp can write more than 8 channels to format 516#451tompollard merged 1 commit intomainfrom
tompollard merged 1 commit intomainfrom
Conversation
Member
|
@alistairewj more tests are always good! looks like the style checks failed. please could you check format and update the PR? |
We should be able to read and write data with more than 8 channels to formats 508, 516, and 524. This test verifies that the digital signal generated when writing to format 516 is identical to the original signal loaded in from a sample record in format 16.
alistairewj
force-pushed
the
test_flac_read_write
branch
from
083d05a to
19a34fd
Compare
Member
Author
|
Ah OK I had autopep8 running and not black. Updated now, fingers crossed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be able to read and write data with more than 8 channels to formats 508, 516, and 524. This test verifies that the digital signal generated when writing to format 516 is identical to the original signal loaded in from a sample record in format 16.
Should catch bugs like those fixed in #450