Handle more than 8 compressed signals in wrsamp#450
Merged
tompollard merged 1 commit intomainfrom May 11, 2023
Merged
Conversation
Since the FLAC format has a hard limit of eight channels, we need to use multiple signal files if a record contains more than eight signals. Commit d1d26ba was meant to do this automatically (when Record.set_default or wfdb.wrsamp is used to generate the signal file names), but this was never tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alistairewj pointed out that there doesn't seem to be an easy way to write a compressed record with more than 8 channels.
It's supposed to be possible to do this:
but the logic I introduced in pull #420 is buggy and currently raises an error.