refactor(itk-wasm): update version to 1.0.0-b.130#385
refactor(itk-wasm): update version to 1.0.0-b.130#385floryst merged 2 commits intoKitware:mainfrom PaulHax:up-wasm
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const inputImages = seriesFiles.map((file) => sanitizeFile(file)); | ||
| const result = await readImageDicomFileSeries(null, { | ||
| inputImages, | ||
| singleSortedSeries: false, | ||
| }); |
There was a problem hiding this comment.
@jadh4v Using the @itk-wasm/dicom package here. This call results in an error. When I copy in a debug build of the .wasm, message is:
CLI::ArgumentMismatch: --input-images: 1 required INPUT_BINARY_FILE:FILE missing
Any suggestions?
There was a problem hiding this comment.
Let me investigate it a little.
There was a problem hiding this comment.
Addressing in a PR here: InsightSoftwareConsortium/ITK-Wasm#886
|
Check to see if repeated calls to readDICOMTags increases memory usage. If not, then we are good to go. |
src/shims-itk-wasm-dicom.d.ts
Outdated
| @@ -0,0 +1,13 @@ | |||
| declare module '@itk-wasm/dicom' { | |||
There was a problem hiding this comment.
why not use the packages's typescript declarations?
There was a problem hiding this comment.
@itk-wasm/dicom package.json's types property points to a missing file.
There was a problem hiding this comment.
PaulHax
changed the title
PaulHax
changed the title
|
LGTM once the package.json conflicts are resolved. |
PaulHax
changed the title
|
Conflicts resolved. Also need to publish and pull in new @itk-wasm/dicom package to get the 4GB memory support. Could do that in another PR. |
PaulHax
changed the title
|
@floryst This is good to go! New 4GB itk-wasm/dicom package incoperated. |
refactor(itk-wasm): update version to 1.0.0-b.130
4 participants
Brings DICOM loading
.wasms that can grow memeory to 4GB. So can load larger DICOM series.TODO
readImageDicomFileSeriesFix emscripten stack memory leak which was worked around via patch-packageNot seeing a heap snapshot change with 1000 iterations ofreadDicomTags