Fixes a stack memory leak and extraneous readDICOMTag XHRs#281
Merged
Conversation
✅ Deploy Preview for volview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for dicomweb failed.
|
Collaborator
|
Very interesting learning here! Regarding |
|
@floryst great find and ideas! A few thoughts building on your suggestions on how to move forward here: InsightSoftwareConsortium/ITK-Wasm#760 -- additional thoughts appreciated! Its seems that we could add an option for execution that provides |
This is a work-around for calling main() multiple times without re-initializing the state of the program.
2 tasks
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
Fixes a stack memory leak and extraneous readDICOMTag XHRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read-dicom-tagspipeline to avoid multiple fetch calls for the same pipeline when reading in a loop. This is less of a concern for image file readers, but it's still good to note it as a potential issue.main()call, since we do not re-initialize the webworker/emscripten program on every call. Cleans up a stack memory leak. (This makes no assumption on the state of the heap in between main() runs.)FYI @thewtex @PaulHax the last point above may be a point of discussion for re-using webworkers. Do we continue to treat main() as the entrypoint, or do we instead expose some separate run() function?