Fixes for tool widget manager life-cycle and SVG tool resize update#344
Merged
floryst merged 4 commits intoKitware:mainfrom Jun 13, 2023
PaulHax:view-widget-lifecycle
Merged
Fixes for tool widget manager life-cycle and SVG tool resize update#344floryst merged 4 commits intoKitware:mainfrom PaulHax:view-widget-lifecycle
floryst merged 4 commits intoKitware:mainfrom
PaulHax:view-widget-lifecycle
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
PaulHax
changed the title
Contributor
|
LGTM! |
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
Fixes for tool widget manager life-cycle and SVG tool resize update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crop3D: Avoids calling widgetManger.addWidget before widgetManager is linked to viewProxy
Reverts conditional rendering of 2D tools on useViewProxyMounted. Applies initialization fix to useViewProxy to avoid adding a widget to widgetManager before linking with viewProxy.
Fixes resize update for SVG widgets by calling ResizeObserver with tool container DIV rather than SVG group element (which did not trigger ResizeObserver callback.)
fixes #343