Allow Python scalars as the search values in dpt.searchsorted
#2225
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2225/index.html |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_104 ran successfully. |
ndgrigorian
force-pushed
the
allow-scalars-searchsorted-search-values
branch
from
b7de201 to
e85940e
Compare
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_104 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_105 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_106 ran successfully. |
ndgrigorian
force-pushed
the
allow-scalars-searchsorted-search-values
branch
from
bda9809 to
b7c56e1
Compare
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_106 ran successfully. |
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
|
|
||
| if not isinstance(x2, usm_ndarray): | ||
| x2 = dpt.asarray(x2, dtype=dt2, usm_type=res_usm_type, sycl_queue=q) | ||
| if x2.dtype != dt: |
There was a problem hiding this comment.
| if x2.dtype != dt: | |
| elif x2.dtype != dt: |
| if x2.dtype != dt: | ||
| x2_buf = _empty_like_orderK(x2, dt) | ||
| dep_evs = _manager.submitted_events | ||
| ht_ev, ev = ti_copy(src=x2, dst=x2_buf, sycl_queue=q, depends=dep_evs) |
There was a problem hiding this comment.
Copying x1 and x2 to the buffers might be done in parallel.
While currently it assumes a sequence execution order: x1 must be copied first and then either x2 is cased to usm_ndarray or x2 is copying to the buffer (but always once the x1 copy kernel is completed).
| skip_if_dtype_not_supported(dt, q) | ||
|
|
||
| x = dpt.zeros(10, dtype=dt, sycl_queue=q) | ||
| py_zeros = ( |
There was a problem hiding this comment.
Would it make sense to parametrize py_zeros with below values instead of iterating over the loop for sc in py_zeros?
3 participants
This PR proposes permitting the search values of
dpt.searchsortedto be Python scalars, a change coming to the 2026 array API specResolves #2224