Skip to content

Handle special characters in XML filenames and sanitize grep output #10586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bric3 merged 1 commit into from
Feb 13, 2026
Merged

Handle special characters in XML filenames and sanitize grep output #10586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .gitlab/count_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,25 @@ echo "Counting tests in $RESULTS_DIR for $TEST_CATEGORY on JVM $JVM_VERSION"

# Find all XML files and count tests
log_verbose "Searching for XML files in $RESULTS_DIR"
for xml_file in $(find "$RESULTS_DIR" -name "*.xml" -type f 2>/dev/null); do
while IFS= read -r -d '' xml_file; do
XML_FILE_COUNT=$((XML_FILE_COUNT + 1))
log_verbose "Processing file $XML_FILE_COUNT: $xml_file"
if [ -f "$xml_file" ]; then
# Count actual <testcase> elements (more accurate than testsuite attributes)
# This matches how datadog-ci counts tests
tests=$(grep -c '<testcase' "$xml_file" 2>/dev/null || echo "0")
tests="${tests//[$'\n\r']/}" # Strip any newlines/carriage returns

# Count <failure>, <error>, and <skipped> tags
# These are more reliable than trying to match testcase+failure in one grep
failures=$(grep -c '<failure' "$xml_file" 2>/dev/null || echo "0")
failures="${failures//[$'\n\r']/}" # Strip any newlines/carriage returns

errors=$(grep -c '<error' "$xml_file" 2>/dev/null || echo "0")
errors="${errors//[$'\n\r']/}" # Strip any newlines/carriage returns

skipped=$(grep -c '<skipped' "$xml_file" 2>/dev/null || echo "0")
skipped="${skipped//[$'\n\r']/}" # Strip any newlines/carriage returns

log_verbose " → tests=$tests, failures=$failures, errors=$errors, skipped=$skipped"

Expand All @@ -68,7 +74,7 @@ for xml_file in $(find "$RESULTS_DIR" -name "*.xml" -type f 2>/dev/null); do
TOTAL_ERRORS=$((TOTAL_ERRORS + errors))
TOTAL_SKIPPED=$((TOTAL_SKIPPED + skipped))
fi
done
done < <(find "$RESULTS_DIR" -name "*.xml" -type f -print0 2>/dev/null)

log_verbose "Processed $XML_FILE_COUNT XML files"

Expand Down
Loading