Handle special characters in XML filenames and sanitize grep output#10586
Merged
Handle special characters in XML filenames and sanitize grep output#10586
Conversation
The script was failing with arithmetic syntax errors when XML filenames contained special characters or when grep output included newlines. - Replace unsafe for loop with proper while/read loop using null-delimited find output - Strip newlines and carriage returns from grep counts before arithmetic operations
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~9fcc486069, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067049
Total [baseline] (10.902 s) : 0, 10902357
Agent [candidate] (1.071 s) : 0, 1070588
Total [candidate] (10.884 s) : 0, 10883624
section appsec
Agent [baseline] (1.24 s) : 0, 1240022
Total [baseline] (11.029 s) : 0, 11028774
Agent [candidate] (1.244 s) : 0, 1243896
Total [candidate] (11.078 s) : 0, 11077936
section iast
Agent [baseline] (1.234 s) : 0, 1233667
Total [baseline] (11.221 s) : 0, 11221255
Agent [candidate] (1.237 s) : 0, 1236720
Total [candidate] (11.151 s) : 0, 11151208
section profiling
Agent [baseline] (1.199 s) : 0, 1199332
Total [baseline] (11.069 s) : 0, 11069304
Agent [candidate] (1.19 s) : 0, 1190242
Total [candidate] (10.882 s) : 0, 10882269
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~9fcc486069, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (629.46 ms) : 0, 629460
BytebuddyAgent [candidate] (631.353 ms) : 0, 631353
AgentMeter [baseline] (29.055 ms) : 0, 29055
AgentMeter [candidate] (29.118 ms) : 0, 29118
GlobalTracer [baseline] (258.056 ms) : 0, 258056
GlobalTracer [candidate] (258.969 ms) : 0, 258969
AppSec [baseline] (32.729 ms) : 0, 32729
AppSec [candidate] (32.914 ms) : 0, 32914
Debugger [baseline] (62.103 ms) : 0, 62103
Debugger [candidate] (61.128 ms) : 0, 61128
Remote Config [baseline] (628.416 µs) : 0, 628
Remote Config [candidate] (643.233 µs) : 0, 643
Telemetry [baseline] (12.365 ms) : 0, 12365
Telemetry [candidate] (15.344 ms) : 0, 15344
Flare Poller [baseline] (6.061 ms) : 0, 6061
Flare Poller [candidate] (4.571 ms) : 0, 4571
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (658.349 ms) : 0, 658349
BytebuddyAgent [candidate] (661.759 ms) : 0, 661759
AgentMeter [baseline] (11.941 ms) : 0, 11941
AgentMeter [candidate] (12.016 ms) : 0, 12016
GlobalTracer [baseline] (258.338 ms) : 0, 258338
GlobalTracer [candidate] (258.918 ms) : 0, 258918
IAST [baseline] (25.219 ms) : 0, 25219
IAST [candidate] (25.307 ms) : 0, 25307
AppSec [baseline] (168.24 ms) : 0, 168240
AppSec [candidate] (167.938 ms) : 0, 167938
Debugger [baseline] (67.417 ms) : 0, 67417
Debugger [candidate] (67.261 ms) : 0, 67261
Remote Config [baseline] (658.659 µs) : 0, 659
Remote Config [candidate] (659.671 µs) : 0, 660
Telemetry [baseline] (9.738 ms) : 0, 9738
Telemetry [candidate] (9.651 ms) : 0, 9651
Flare Poller [baseline] (3.697 ms) : 0, 3697
Flare Poller [candidate] (3.738 ms) : 0, 3738
section iast
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (797.107 ms) : 0, 797107
BytebuddyAgent [candidate] (798.935 ms) : 0, 798935
AgentMeter [baseline] (11.269 ms) : 0, 11269
AgentMeter [candidate] (11.287 ms) : 0, 11287
GlobalTracer [baseline] (249.167 ms) : 0, 249167
GlobalTracer [candidate] (249.237 ms) : 0, 249237
IAST [baseline] (26.848 ms) : 0, 26848
IAST [candidate] (27.1 ms) : 0, 27100
AppSec [baseline] (33.415 ms) : 0, 33415
AppSec [candidate] (32.392 ms) : 0, 32392
Debugger [baseline] (66.852 ms) : 0, 66852
Debugger [candidate] (68.665 ms) : 0, 68665
Remote Config [baseline] (534.267 µs) : 0, 534
Remote Config [candidate] (533.564 µs) : 0, 534
Telemetry [baseline] (8.534 ms) : 0, 8534
Telemetry [candidate] (8.588 ms) : 0, 8588
Flare Poller [baseline] (3.514 ms) : 0, 3514
Flare Poller [candidate] (3.49 ms) : 0, 3490
section profiling
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (687.612 ms) : 0, 687612
BytebuddyAgent [candidate] (682.147 ms) : 0, 682147
AgentMeter [baseline] (8.698 ms) : 0, 8698
AgentMeter [candidate] (8.651 ms) : 0, 8651
GlobalTracer [baseline] (217.482 ms) : 0, 217482
GlobalTracer [candidate] (216.212 ms) : 0, 216212
AppSec [baseline] (33.031 ms) : 0, 33031
AppSec [candidate] (32.507 ms) : 0, 32507
Debugger [baseline] (67.824 ms) : 0, 67824
Debugger [candidate] (67.04 ms) : 0, 67040
Remote Config [baseline] (621.977 µs) : 0, 622
Remote Config [candidate] (617.03 µs) : 0, 617
Telemetry [baseline] (8.943 ms) : 0, 8943
Telemetry [candidate] (8.977 ms) : 0, 8977
Flare Poller [baseline] (3.838 ms) : 0, 3838
Flare Poller [candidate] (3.739 ms) : 0, 3739
ProfilingAgent [baseline] (99.604 ms) : 0, 99604
ProfilingAgent [candidate] (99.343 ms) : 0, 99343
Profiling [baseline] (100.187 ms) : 0, 100187
Profiling [candidate] (99.912 ms) : 0, 99912
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~9fcc486069, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066755
Total [baseline] (8.734 s) : 0, 8733655
Agent [candidate] (1.065 s) : 0, 1065498
Total [candidate] (8.727 s) : 0, 8727423
section iast
Agent [baseline] (1.243 s) : 0, 1242590
Total [baseline] (9.354 s) : 0, 9354491
Agent [candidate] (1.235 s) : 0, 1234707
Total [candidate] (9.352 s) : 0, 9351722
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~9fcc486069, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (630.766 ms) : 0, 630766
BytebuddyAgent [candidate] (629.958 ms) : 0, 629958
AgentMeter [baseline] (28.939 ms) : 0, 28939
AgentMeter [candidate] (28.967 ms) : 0, 28967
GlobalTracer [baseline] (257.546 ms) : 0, 257546
GlobalTracer [candidate] (258.112 ms) : 0, 258112
AppSec [baseline] (32.727 ms) : 0, 32727
AppSec [candidate] (32.836 ms) : 0, 32836
Debugger [baseline] (61.128 ms) : 0, 61128
Debugger [candidate] (61.098 ms) : 0, 61098
Remote Config [baseline] (635.576 µs) : 0, 636
Remote Config [candidate] (620.784 µs) : 0, 621
Telemetry [baseline] (12.343 ms) : 0, 12343
Telemetry [candidate] (12.075 ms) : 0, 12075
Flare Poller [baseline] (6.146 ms) : 0, 6146
Flare Poller [candidate] (5.274 ms) : 0, 5274
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (803.928 ms) : 0, 803928
BytebuddyAgent [candidate] (798.678 ms) : 0, 798678
AgentMeter [baseline] (11.529 ms) : 0, 11529
AgentMeter [candidate] (11.28 ms) : 0, 11280
GlobalTracer [baseline] (249.991 ms) : 0, 249991
GlobalTracer [candidate] (248.956 ms) : 0, 248956
IAST [baseline] (27.241 ms) : 0, 27241
IAST [candidate] (26.951 ms) : 0, 26951
AppSec [baseline] (34.976 ms) : 0, 34976
AppSec [candidate] (34.79 ms) : 0, 34790
Debugger [baseline] (65.508 ms) : 0, 65508
Debugger [candidate] (64.912 ms) : 0, 64912
Remote Config [baseline] (553.394 µs) : 0, 553
Remote Config [candidate] (536.085 µs) : 0, 536
Telemetry [baseline] (8.631 ms) : 0, 8631
Telemetry [candidate] (8.595 ms) : 0, 8595
Flare Poller [baseline] (3.504 ms) : 0, 3504
Flare Poller [candidate] (3.489 ms) : 0, 3489
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 14 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~9fcc486069, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1169, 1191
. : milestone, 1180,
iast (3.296 ms) : 3252, 3339
. : milestone, 3296,
iast_FULL (5.858 ms) : 5799, 5916
. : milestone, 5858,
iast_GLOBAL (3.525 ms) : 3477, 3573
. : milestone, 3525,
profiling (2.102 ms) : 2081, 2123
. : milestone, 2102,
tracing (1.825 ms) : 1809, 1841
. : milestone, 1825,
section candidate
no_agent (1.2 ms) : 1188, 1212
. : milestone, 1200,
iast (3.291 ms) : 3246, 3336
. : milestone, 3291,
iast_FULL (5.928 ms) : 5868, 5988
. : milestone, 5928,
iast_GLOBAL (3.515 ms) : 3468, 3562
. : milestone, 3515,
profiling (1.991 ms) : 1974, 2009
. : milestone, 1991,
tracing (1.843 ms) : 1828, 1858
. : milestone, 1843,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~9fcc486069, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section baseline
no_agent (17.229 ms) : 17057, 17400
. : milestone, 17229,
appsec (19.396 ms) : 19195, 19597
. : milestone, 19396,
code_origins (17.592 ms) : 17418, 17766
. : milestone, 17592,
iast (17.541 ms) : 17364, 17717
. : milestone, 17541,
profiling (18.56 ms) : 18372, 18749
. : milestone, 18560,
tracing (17.475 ms) : 17302, 17647
. : milestone, 17475,
section candidate
no_agent (19.145 ms) : 18950, 19341
. : milestone, 19145,
appsec (19.206 ms) : 19011, 19400
. : milestone, 19206,
code_origins (17.347 ms) : 17176, 17518
. : milestone, 17347,
iast (17.576 ms) : 17400, 17752
. : milestone, 17576,
profiling (19.408 ms) : 19211, 19604
. : milestone, 19408,
tracing (19.546 ms) : 19353, 19739
. : milestone, 19546,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~9fcc486069, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section baseline
no_agent (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
appsec (14.68 s) : 14680000, 14680000
. : milestone, 14680000,
iast (18.38 s) : 18380000, 18380000
. : milestone, 18380000,
iast_GLOBAL (18.128 s) : 18128000, 18128000
. : milestone, 18128000,
profiling (15.467 s) : 15467000, 15467000
. : milestone, 15467000,
tracing (14.637 s) : 14637000, 14637000
. : milestone, 14637000,
section candidate
no_agent (15.42 s) : 15420000, 15420000
. : milestone, 15420000,
appsec (15.002 s) : 15002000, 15002000
. : milestone, 15002000,
iast (18.323 s) : 18323000, 18323000
. : milestone, 18323000,
iast_GLOBAL (17.813 s) : 17813000, 17813000
. : milestone, 17813000,
profiling (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
tracing (14.771 s) : 14771000, 14771000
. : milestone, 14771000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~9fcc486069, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1487
. : milestone, 1475,
appsec (2.536 ms) : 2481, 2592
. : milestone, 2536,
iast (2.261 ms) : 2192, 2330
. : milestone, 2261,
iast_GLOBAL (2.305 ms) : 2235, 2375
. : milestone, 2305,
profiling (2.093 ms) : 2038, 2148
. : milestone, 2093,
tracing (2.074 ms) : 2020, 2128
. : milestone, 2074,
section candidate
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (3.793 ms) : 3572, 4014
. : milestone, 3793,
iast (2.258 ms) : 2189, 2327
. : milestone, 2258,
iast_GLOBAL (2.292 ms) : 2223, 2362
. : milestone, 2292,
profiling (2.086 ms) : 2031, 2141
. : milestone, 2086,
tracing (2.064 ms) : 2010, 2117
. : milestone, 2064,
|
AlexeyKuznetsov-DD
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
The script was failing with arithmetic syntax errors when XML filenames contained special characters or when grep output included newlines.