Generate one ical event for meetings instead of one per weekday#339
Closed
natep-tech wants to merge 9 commits intoComputerScienceHouse:developfrom
Closed
Generate one ical event for meetings instead of one per weekday#339natep-tech wants to merge 9 commits intoComputerScienceHouse:developfrom
natep-tech wants to merge 9 commits intoComputerScienceHouse:developfrom
Conversation
Updated the generateIcal() function. 1. Updated the code that gets the starting date of the course, to use the weekday number of the term start date. This way if the term starts on a day other than Monday, it'll still correctly generate the start day of the course., 2. Added code that'll generate a single series for a multiday course (Mon,Web,Fri for example) to simplify calendars. If any details are different between the different times (different location or times, for example) it'll fallback to the old code that makes separate series for each listed time in the course.
Updated the generateIcal() function: 1. Updated the code that gets the starting date of the course, to use the weekday number of the term start date. This way if the term starts on a day other than Monday, it'll still correctly generate the start day of the course., 2. Added code that'll generate a single series for a multiday course (Mon,Web,Fri for example) to simplify calendars. If any details are different between the different times (different location or times, for example) it'll fallback to the old code that makes separate series for each listed time in the course.
This was referenced Dec 26, 2023
Merged
Member
|
Please fix merge conflicts |
Mstrodl
changed the title
Mstrodl
changed the title
Author
|
Merge conflicts should be resolved now. |
Member
|
Hm. The diff still doesn't look right. Try rebasing against develop? |
Updated the generateIcal() function. 1. Updated the code that gets the starting date of the course, to use the weekday number of the term start date. This way if the term starts on a day other than Monday, it'll still correctly generate the start day of the course., 2. Added code that'll generate a single series for a multiday course (Mon,Web,Fri for example) to simplify calendars. If any details are different between the different times (different location or times, for example) it'll fallback to the old code that makes separate series for each listed time in the course.
Author
|
I ran a rebase again, hopefully that fixes everything |
Mstrodl
requested changes
Jan 8, 2024
Member
Mstrodl
left a comment
Mstrodl
left a comment
There was a problem hiding this comment.
I'm going to see if I can fix this
Author
|
I apologize for the trouble with this PR. Thank you for your patience, the two comments you left should have been resolved by my latest commit. I'm doing another quality review tonight to ensure the rest of the file is up to snuff. |
Member
|
superseded by #343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the
generateIcal()function. (Breaking out the multiple changes from #325 into separate PRs for clarity)Added code that'll generate a single series for a multi-day course (Mon,Web,Fri for example) to simplify calendars (see the iCal specification for RRULE). If any details are different between the different times (different location or times, for example) it'll fallback to the old code that makes separate series for each listed time in the course. #63