Update Schedule.php to fix iCal Generation#325
Closed
natep-tech wants to merge 1 commit intoComputerScienceHouse:developfrom
Closed
Update Schedule.php to fix iCal Generation#325natep-tech wants to merge 1 commit intoComputerScienceHouse:developfrom
natep-tech wants to merge 1 commit intoComputerScienceHouse:developfrom
Conversation
Updated the generateIcal() function. 1. Updated the code that gets the starting date of the course, to use the weekday number of the term start date. This way if the term starts on a day other than Monday, it'll still correctly generate the start day of the course., 2. Added code that'll generate a single series for a multiday course (Mon,Web,Fri for example) to simplify calendars. If any details are different between the different times (different location or times, for example) it'll fallback to the old code that makes separate series for each listed time in the course.
Author
|
I need to update the first fix to support term start dates after the first day a class is supposed to start (Term starts Wednesday, so Tuesday/Thursday classes start on Thursday) |
Contributor
Author
Due to the issue #326 I am unable to finish this without correct data. |
Contributor
|
@Lontronix are you able to help with this? |
Contributor
Merged
Author
Author
|
I broke out the unreviewed part into its own PR: #339 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the
generateIcal()function.Updated the code that gets the starting date of the course, to use the weekday number of the term start date. This way if the term starts on a day other than Monday, it'll still correctly generate the start day of the course. iCal Export Dates placed wrong #310 Schedule offsets dates by one day #232
Added code that'll generate a single series for a multi-day course (Mon,Web,Fri for example) to simplify calendars (see the iCal specification for RRULE). If any details are different between the different times (different location or times, for example) it'll fallback to the old code that makes separate series for each listed time in the course. Exporting to Google Calendar Creates Separate Series #63