Set up website to grab and serve preseed#42
Merged
wilsonmcdade merged 8 commits intoComputerScienceHouse:devfrom Apr 9, 2023
Merged
Set up website to grab and serve preseed#42wilsonmcdade merged 8 commits intoComputerScienceHouse:devfrom
wilsonmcdade merged 8 commits intoComputerScienceHouse:devfrom
Conversation
…feature-gamejam Added gamejam page
asimonson1125
approved these changes
Apr 4, 2023
Member
asimonson1125
left a comment
asimonson1125
left a comment
There was a problem hiding this comment.
I think you could have redirected the user to the URL rather than have the website save it and send its own copy since it's static but this works too. lgtm
Member
Author
|
@asimonson1125 Yeah, I was worried that that might confuse the preseed. I could change it to do that and then test it in dev...? |
Collaborator
|
Ready to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.