Closed
Conversation
851664d to
0ff92e7
Compare
sejas
commented
Feb 24, 2026
| "allow-plugins": { | ||
| "dealerdirect/phpcodesniffer-composer-installer": true | ||
| "dealerdirect/phpcodesniffer-composer-installer": true, | ||
| "phpstan/extension-installer": true |
Member
Author
There was a problem hiding this comment.
This is also added in main wp-cli repo: https://github.com/wp-cli/wp-cli/blob/dc880193b6f20673fae82acf07ffcb4ce32465a9/composer.json#L34
phpcompatibility/php-compatibility dev-develop moved to squizlabs/php_codesniffer ^4.0.1, which conflicts with wp-coding-standards/wpcs ^3 requiring ^3.x. Upgrading wp-cli-tests to ^5.0 resolves this by aligning all PHPCS-related dependencies. The explicit phpcompatibility/php-compatibility requirement is removed since wp-cli-tests v5 pulls it in transitively as ^10.0. Also adds phpstan/extension-installer to allow-plugins and configures PHPStan with a baseline for existing errors, as required by wp-cli-tests v5 which added PHPStan support (matching wp-cli/wp-cli upstream config). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
0ff92e7 to
6f066d0
Compare
|
Hey @sejas 👋🏼 🙂 I have noticed that @JanJakes has opened a related PR: #21. Edit: @anaemnesis apologies - I have tagged you here initially. That was autocomplete error. |
Member
Author
|
@ivan-ottinger , thanks for pointing it out. I've closed my PR in favor of Jan's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I found the CI was failing when I created a PR that only updated AGENTS.md, so I decided to fix the CI in a separate PR.
wp-cli/wp-cli-testsfrom^4.3.2to^5.0to resolve the PHPCS version conflictphpcompatibility/php-compatibilitydependency (now pulled in transitively by wp-cli-tests v5 as^10.0)minimum-stability: dev+prefer-stable: truesince PHPCompatibility 10.x is still in alpha and WPCS is ondev-developContext
CI was failing because
phpcompatibility/php-compatibility dev-developmoved tosquizlabs/php_codesniffer ^4.0.1, which conflicts withwp-coding-standards/wpcs ^3requiring^3.x. These two packages need different major versions of php_codesniffer, making them mutually exclusive.Test plan
composer installresolves without conflicts)🤖 Generated with Claude Code