Conversation
fdd9f48 to
188328c
Compare
188328c to
6fd70ff
Compare
The dev-develop branch of phpcompatibility/php-compatibility now requires squizlabs/php_codesniffer ^4, which conflicts with the ^3 required by wp-cli-tests v4. Additionally, the shared CI workflow (wp-cli/.github#208) now runs code coverage on PHP 8.5, which needs the newer php-code-coverage library from v5. Changes: - Upgrade wp-cli/wp-cli-tests from ^4.3.2 to ^5.0. - Add phpcompatibility/php-compatibility ^10.0@alpha and wp-coding-standards/wpcs @dev to satisfy transitive deps that lack stable releases. - Add phpstan script and config, required by wp-cli-tests v5. - Add stubs for WP_SQLite_Driver, WP_SQLite_Translator, and WP_SQLite_Connection (loaded at runtime by WordPress, not available via Composer). - Allow phpstan/extension-installer Composer plugin.
6fd70ff to
12719da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
dev-developbranch ofphpcompatibility/php-compatibilitynow requiressquizlabs/php_codesniffer ^4, which conflicts with^3required bywp-cli-tests v4. This breaks all CI jobs. Additionally, the shared CI workflow (wp-cli/.github#208) now runs code coverage on PHP 8.5, which needs the newerphp-code-coveragelibrary from v5.Changes
^4.3.2to^5.0, resolving the codesniffer version conflict and adding PHP 8.5 coverage support.phpcompatibility/php-compatibility ^10.0@alphaandwp-coding-standards/wpcs @dev, since these packages don't have stable releases compatible with codesniffer^4yet.wp-cli-tests v5. Starts at level 0 with stubs forWP_SQLite_Driver,WP_SQLite_Translator, andWP_SQLite_Connection(loaded at runtime by WordPress, not available via Composer).wp-cli-tests v5.