[Feature] Courtroom slides - Based once again#966
Merged
Conversation
fix evidence presenting sfx playing at literally 100x intended volume fix "def2" etc wrong evidence icon position, remove inaccurate evidence positions
* Complete AOLayer reimplementation * Reimplemented sliding as well.
* Fixed emote synchronization * Still requires identical frame count. Will still cause freeze as it syncs. * Fixed frame effects not working on idle and talk emotes. * Characters are now repositioned after background sliding is over.
* Removed theme submodule. * This should be handled by the CI. * Fixed effects not disappearing when they should (cull / repeat)
Contributor
|
The format has been updated to the following: scaling = smooth
positions = wit2
[court:def]
rect=0, 0, 640, 384
slide_ms_pro=550
slide_ms_wit=500
[court:wit]
rect=1147, 0, 640, 384
slide_ms_pro=500
slide_ms_def=500
[court:pro]
rect=2294, 0, 640, 384
slide_ms_def=550
slide_ms_wit=500Biggest difference is that instead of a position in space it's a rect that covers the background. |
TrickyLeifa
approved these changes
May 23, 2024
Closed
Salanto
approved these changes
May 24, 2024
Contributor
Salanto
left a comment
There was a problem hiding this comment.
Improves Performance
Improves readability
Improves functionality
Improves improvements
After some testing of regular AO2 animation behaviour frameFX and co seem to work correctly too. No reason to wait any longer.
(The side logic is looking worse for wear, but that should be overhauled in another branch/PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor of #869, now with 70% fewer merge conflicts.
Took the old code verbatim and added pair support,. As far as my testing shows, this kinda just works.
Formatting required for setup:
Full courtroom image (should be named "court.png" but can work with any name)
Design.ini parameters:
where "court:pos" is the main image and the name of its subposition.
pos_centeris the pixel position of the center of the part of the image you want to be a positionand the transition duration settings are formatted as
slide_ms_posand a duration in milliseconds.Additionally, there is support for giving characters a special pose during transitions if an "Objection!" shout was used.
This PR also adds a checkbox to the main UI to enable or disable sending the new MS parameter
SLIDEwhich dictates whether a message is able to trigger a slide animation.Additionally, a global setting is now in the settings menu to disable slide animations for yourself.
Rebased from #959.