Sanity check before removing the ui element.#612
Merged
oldmud0 merged 2 commits intoAttorneyOnline:masterfrom Dec 24, 2021
Salanto:fix-#610
Merged
Sanity check before removing the ui element.#612oldmud0 merged 2 commits intoAttorneyOnline:masterfrom Salanto:fix-#610
oldmud0 merged 2 commits intoAttorneyOnline:masterfrom
Salanto:fix-#610
Conversation
oldmud0
approved these changes
Dec 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to have been introduced by #389.
We instantly hide the UI element as on_sfx_dropdown_changed is called right after we pick the sfx as there is no check to prevent hiding. This PR corrects this. A simple check, if we are not on the first SFX item, should correct this.