Overhaul sound lists to introduce aliases, rethink editing behavior#389
Merged
stonedDiscord merged 7 commits intomasterfrom Jan 13, 2021
Merged
Overhaul sound lists to introduce aliases, rethink editing behavior#389stonedDiscord merged 7 commits intomasterfrom
stonedDiscord merged 7 commits intomasterfrom
Conversation
…aying a preanimation that behaves similar to the Default option
* Allow aliases. .ini file syntax is "filename = alias". * Do not allow editing the .ini files from the client anymore. * The sound list dropdown is still editable, but all it does is play your custom sfx without adding it to any files. * Overhaul get_char_sfx
Crystalwarrior
added
enhancement
# Conflicts: # src/courtroom.cpp
in1tiate
previously approved these changes
Jan 11, 2021
Member
in1tiate
left a comment
in1tiate
left a comment
There was a problem hiding this comment.
I like this behavior more, it's closer to the way iniswaps now work.
oldmud0
previously approved these changes
Jan 11, 2021
# Conflicts: # src/courtroom.cpp
stonedDiscord
approved these changes
Jan 13, 2021
Member
stonedDiscord
left a comment
stonedDiscord
left a comment
There was a problem hiding this comment.
average courtroom.cpp spaghetti
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You will no longer overwrite the preexisting sondlists, what happens instead is you can play a custom sfx based on your input in the box. It will clear if sticky sfx are off.
Aliases are functional as well,
filename = aliasOld behavior with just filenames still works.