Skip to content

Conversation

@jordanoverbye
Copy link

@jordanoverbye jordanoverbye commented Nov 11, 2025

What's the problem this PR addresses?

Currently the dedupe command always runs project.installWithNewReport() even when no packages need deduplication, causing unnecessary installs and lockfile updates.

How did you fix it?

Exit early if no packages need deduping. Only run project.installWithNewReport() when necessary.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@jordanoverbye jordanoverbye force-pushed the joverbye-dedupe-optimisation branch from c674609 to 2577eed Compare November 11, 2025 07:09
@jordanoverbye jordanoverbye marked this pull request as ready for review November 11, 2025 07:21
@clemyan
Copy link
Member

clemyan commented Dec 19, 2025

Only @yarnpkg/cli and @yarnpkg/plugin-essentials should be released. Other packages should be marked as declined.

LGTM, but I'd like to have a second pair of eyes to look over it.

@jordanoverbye jordanoverbye force-pushed the joverbye-dedupe-optimisation branch from 2a34bf8 to 08a853a Compare January 5, 2026 00:24
@jordanoverbye
Copy link
Author

Thank you for the review @clemyan! I've just pushed a change to the versions file so only @yarnpkg/cli and @yarnpkg/plugin-essentials should now be released.

@jordanoverbye jordanoverbye force-pushed the joverbye-dedupe-optimisation branch from 2ba936d to 161675d Compare January 5, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants