Recalculate menu order on insertion or deletion

[petruchek]

New private method called reorder_menu_items() which is being called after any menu item is being deleted or new menu item is being added and it has explicitly set position.

Issue reported and briefly discussed here: #493

[petruchek]

Hi there @schlessera

Any news on this PR being merged?

Thanks

[schlessera]

Hi @petruchek,

Yes, I'd like to move this forward. However, we'll need Behat tests for this first. Can you add tests to assert that the menu IDs are correctly modified?

Let me know if you need assistance with writing the tests!

[petruchek]

Let me know if you need assistance with writing the tests!

@schlessera, thank you for your response.

Could you please guide me a little, please?

I'm assuming I need to modify features/menu-item.feature. Is this correct?
Do you think I need to create a separate scenario? Or I should modify existing scenarios?

Thank you for your time (very much)

[schlessera]

@petruchek

I'm assuming I need to modify features/menu-item.feature. Is this correct?

Yes, that's the one to edit.

Do you think I need to create a separate scenario? Or I should modify existing scenarios?

Please create a separate scenario. In the existing tests, you can already see how the position is being represented in the output lists, so it should be relatively straight-forward to copy one of the existing scenarios and adapt it to test this PR.

[petruchek]

@petruchek

I'm assuming I need to modify features/menu-item.feature. Is this correct?

Yes, that's the one to edit.

Do you think I need to create a separate scenario? Or I should modify existing scenarios?

Please create a separate scenario. In the existing tests, you can already see how the position is being represented in the output lists, so it should be relatively straight-forward to copy one of the existing scenarios and adapt it to test this PR.

Hi there @schlessera,

Is it something that still makes sense doing? Please let me know.

[schlessera]

Hey @petruchek,
Yes, this still makes sense.

[schlessera]

Thanks for the PR, @petruchek !