Skip to content

Bail with a warning when deleting custom post types without --force #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schlessera merged 12 commits into from
Dec 12, 2018
Merged

Bail with a warning when deleting custom post types without --force #188

schlessera merged 12 commits into from
Dec 12, 2018

Conversation

@Mte90
Copy link
Contributor

@Mte90 Mte90 commented Jul 20, 2018

Closes #128

@Mte90
Copy link
Contributor Author

Mte90 commented Jul 20, 2018

Do we need a behat test for that?

@Mte90
Copy link
Contributor Author

Mte90 commented Jul 20, 2018

From what I can see in post.feature there are post id but there is no way to detect the post type itself so I am not sure what to do for that part.

@Mte90
Copy link
Contributor Author

Mte90 commented Jul 20, 2018

The tests are failing on the case of force and I don't understand why it's happening.
When I tried the command on a site was working, if someone can help on that will be appreciated :-)

@Mte90
Copy link
Contributor Author

Mte90 commented Dec 12, 2018

thanks for the help!

@schlessera
Copy link
Member

schlessera commented Dec 12, 2018

I had trouble figuring out what the actual problem was... until I noticed that the failure came from a different test and it was just because the tests were running out of order.

@schlessera schlessera added the command:post-delete Related to 'post delete' command label Dec 12, 2018
@schlessera schlessera added this to the 2.0.2 milestone Dec 12, 2018
@schlessera schlessera merged commit 459fba6 into wp-cli:master Dec 12, 2018
@schlessera schlessera changed the title Delete alert in case of custom post type Bail with a warning when deleting custom post types without --force Dec 12, 2018
@ocean90 ocean90 mentioned this pull request May 12, 2020
Open
Copilot AI mentioned this pull request Nov 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

command:post-delete Related to 'post delete' command

Projects

None yet

Milestone

2.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@Mte90 @schlessera