Require kwargs for multi param methods#325
Merged
Conversation
tribble
force-pushed
the
require-kwargs-for-multi-param-methods
branch
from
14efb52 to
84d474d
Compare
tribble
commented
Aug 8, 2024
| self.http_client, mock_enroll_factor_response_sms, 200 | ||
| ) | ||
| enroll_factor = self.mfa.enroll_factor("sms", None, None, "9204448888") | ||
| enroll_factor = self.mfa.enroll_factor(type="sms", phone_number="9204448888") |
Author
There was a problem hiding this comment.
It seemed silly to continue to pass the totp fields here. Removed them.
mattgd
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch multi-arg public SDK methods to keyword-only.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.