Modify FIPS build and fix AES-GCM stream handling for FIPS#181
Merged
aidangarske merged 2 commits intowolfSSL:masterfrom Jun 20, 2025
Merged
Modify FIPS build and fix AES-GCM stream handling for FIPS#181aidangarske merged 2 commits intowolfSSL:masterfrom
aidangarske merged 2 commits intowolfSSL:masterfrom
Conversation
…rypto, fix AES-GCM FIPS stream handling.
This was referenced Jun 19, 2025
SparkiDev
approved these changes
Jun 19, 2025
aidangarske
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now wolfProvider has been building underlying wolfSSL FIPS using the same flags as default, including --enable-all-crypto. This is not a valid option for wolfSSL FIPS and it enables many algo flags in options.h that dont or should not have underlying crypto support. Fix build to use only needed flags.
Depending on build flags, wc_AesGcmDecrypt() implementation may or may not yield plaintext on a auth tag error. Modify stream handling to use wc_AesGcmEncrypt() instead to yield plaintext on all calls except the last.