refactor!: allow only Array for the proxy option#4694
Merged
Conversation
Codecov ReportBase: 92.34% // Head: 92.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #4694 +/- ##
==========================================
- Coverage 92.34% 92.14% -0.21%
==========================================
Files 15 15
Lines 1555 1540 -15
Branches 581 574 -7
==========================================
- Hits 1436 1419 -17
- Misses 110 112 +2
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
snitin315
requested review from
alexander-akait,
anshumanv and
hiroppy
as code owners
| } | ||
| ); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
We will need to write migration guide on this, because it is still the popular syntax 😞
Member
Author
There was a problem hiding this comment.
Yes. We will create a separate migration guide for v5.
alexander-akait
approved these changes
Dec 27, 2022
snitin315
added a commit
that referenced
this pull request
Mar 16, 2023
* refactor!: allow only Array for the proxy option * test: fix ci * chore: fix lint
snitin315
added a commit
that referenced
this pull request
Apr 7, 2023
* refactor!: allow only Array for the proxy option * test: fix ci * chore: fix lint
snitin315
added a commit
that referenced
this pull request
May 6, 2023
* refactor!: allow only Array for the proxy option * test: fix ci * chore: fix lint
snitin315
added a commit
that referenced
this pull request
May 25, 2023
* refactor!: allow only Array for the proxy option * test: fix ci * chore: fix lint
snitin315
added a commit
that referenced
this pull request
Jan 13, 2024
* refactor!: allow only Array for the proxy option * test: fix ci * chore: fix lint
alexander-akait
pushed a commit
that referenced
this pull request
Jan 22, 2024
* refactor!: allow only Array for the proxy option * test: fix ci * chore: fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes, updated tests to use
Arraysyntax only.Motivation / Use-Case
Resolve TODO.
Breaking Changes
BREAKING CHANGE: the proxy option schema now only accepts an array
Additional Info