Skip to content

Encode correctly OCSP NONCE extension #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrts merged 1 commit into from
Feb 16, 2024
Merged

Encode correctly OCSP NONCE extension #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/main/java/eu/webeid/security/validator/ocsp/OcspRequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import org.bouncycastle.cert.ocsp.OCSPReq;
import org.bouncycastle.cert.ocsp.OCSPReqBuilder;

import java.io.IOException;
import java.security.SecureRandom;
import java.util.Objects;

Expand Down Expand Up @@ -82,19 +83,23 @@ public OCSPReq build() throws OCSPException {
builder.addRequest(Objects.requireNonNull(certificateId, "certificateId"));

if (ocspNonceEnabled) {
addNonce(builder);
try {
addNonce(builder);
} catch (IOException e) {
throw new OCSPException("Failed to generate OCSP NONCE extension", e);
}
}

return builder.build();
}

private void addNonce(OCSPReqBuilder builder) {
private void addNonce(OCSPReqBuilder builder) throws IOException {
final byte[] nonce = new byte[32];
GENERATOR.nextBytes(nonce);

final Extension[] extensions = new Extension[]{
new Extension(OCSPObjectIdentifiers.id_pkix_ocsp_nonce, false,
new DEROctetString(nonce))
new DEROctetString(new DEROctetString(nonce)))
};
builder.setRequestExtensions(new Extensions(extensions));
}
Expand Down