fix: support file:// protocol seen in node14 ESM modules#15
Open
chrisdickinson wants to merge 1 commit intowatson:masterfrom
Open
fix: support file:// protocol seen in node14 ESM modules#15chrisdickinson wants to merge 1 commit intowatson:masterfrom
chrisdickinson wants to merge 1 commit intowatson:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I've been testing ESM support for a work project, and noticed that filenames in stack traces were prefixed by
file://. As a result,getSourceContextwould return empty results, whilegetRelativeFileNamewas unable to properly truncate the filename. This change appears to fix the issue.I've added some pretty bare-bones tests to assert that the change works. I rearranged
package.jsona bit to get it to work (movingstandardtonpm run lint, run as aposttestcommand) but please discard that change if it's not your cup of tea!