fix(applet): preserve active component when filtering#1065
Open
skirtles-code wants to merge 1 commit intovuejs:mainfrom
Open
fix(applet): preserve active component when filtering#1065skirtles-code wants to merge 1 commit intovuejs:mainfrom
skirtles-code wants to merge 1 commit intovuejs:mainfrom
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
@vue/devtools-applet
@vue/devtools-core
@vue/devtools
@vue/devtools-api
@vue/devtools-kit
@vue/devtools-electron
@vue/devtools-shared
@vue/devtools-ui
vite-plugin-vue-devtools
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1062.
When filtering using the
Find components...input, the selected component gets reset every time there's a re-render in the target application.I've adjusted the logic to preserve the old selection whenever possible. The selection is only reset if the previously selected component is no longer available. This doesn't just apply to re-renders, it also applies to changing the search value.
There's one specific use case I was particularly keen to improve. If you use the search box to find a component, you can select it and then clear the search value. The selection is now preserved, allowing you to see exactly where that component is in the tree. To get this all working smoothly I also needed to adjust the logic for automatically expanding nodes.
Most of the logic I needed already existed elsewhere in the same file, so I've introduced some helpers to avoid duplicating that logic.