break[array]: lazy compare function#6495
Merged
joseph-isaacs merged 22 commits intodevelopfrom Feb 16, 2026
Merged
Conversation
Merging this PR will improve performance by 46.45%
Performance Changes
Comparing 
Footnotes
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/lazy-compare
branch
from
974140c to
9709457
Compare
# Conflicts: # vortex-array/public-api.lock
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (3)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
commented
Feb 16, 2026
Contributor
Author
There was a problem hiding this comment.
directly in the expr
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
robert3005
reviewed
Feb 16, 2026
| use crate::arrays::TakeExecuteAdaptor; | ||
| use crate::kernel::ParentKernelSet; | ||
|
|
||
| // TODO(joe): add CompareExecuteAdaptor to push comparisons through the mask without canonicalizing. |
Contributor
|
You want to change encodings/fsst/benches/fsst_compress.rs to use RecursiveCanonical, right now you have 50x improvement because functions are constant |
robert3005
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lazy compare, see: #5921
##break
vortex_array compute/compare is not lazy.