cmake: add explicit build options to QNX presets #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
MariusBgm
reviewed
Jan 26, 2026
CMakePresets.json
Outdated
| { | ||
| "name": "x-cross-qnx-x86_64", | ||
| "generator": "Unix Makefiles", | ||
| "generator": "Ninja", |
Collaborator
There was a problem hiding this comment.
I recall having a hard time crosscompiling using Ninja on Windos when I created this. does this work now out of the box?
CMakePresets.json
Outdated
| "SILKIT_BUILD_UTILITIES": "ON", | ||
| "SILKIT_WARNINGS_AS_ERRORS": "OFF", | ||
| "SILKIT_PACKAGE_SYMBOLS": "ON", | ||
| "SILKIT_INSTALL_SOURCE": "OFF", |
Collaborator
There was a problem hiding this comment.
Not sure why INSTALL_SOURCE is significant here. We do not create packages using this preset anyways?
Contributor
Author
There was a problem hiding this comment.
Removed it, since it is the default (OFF) anyway
VDanielEdwards
approved these changes
Jan 27, 2026
Member
VDanielEdwards
left a comment
VDanielEdwards
left a comment
There was a problem hiding this comment.
Looks good! 👍 I saw that the preset defined the environment variable SILKIT_CMAKE_PRESET_BUILD_PLATFORM. However this does not seem to be used anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QNX needs specific CMAKE Options since not all options work with the SDK and toolchains for QNX
Developer checklist (address before review)
Changelog.md updatedNo user visible changePrepared update for depending repositoriesDocumentation updated (public API changes only)API docstrings updated (public API changes only)