Remove uses of deprecated wasm TransferrableModule#101
Merged
hashseed merged 1 commit intov8:node-ci-2019-09-30from Oct 21, 2019
Merged
Remove uses of deprecated wasm TransferrableModule#101hashseed merged 1 commit intov8:node-ci-2019-09-30from
hashseed merged 1 commit intov8:node-ci-2019-09-30from
Conversation
WasmModuleObject::TransferrableModule is deprecated and will be removed in V8 v8.0. Replace all uses by CompiledWasmModule.
Member
Author
|
Note: This is blocking the actual removal of the deprecated type, see https://crrev.com/c/1864947. |
addaleax
approved these changes
Oct 18, 2019
Member
Author
|
Thanks for approving. Looks like I don't have write access to this repo. Do you have? Can you merge this PR for me? |
|
No, only some people on the V8 team do, afaik. |
2 tasks
hashseed
approved these changes
Oct 21, 2019
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Nov 8, 2019
WasmModuleObject::TransferrableModule is deprecated and will be removed in V8 v8.0. Replace all uses by CompiledWasmModule. Refs: v8#101
addaleax
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 8, 2019
WasmModuleObject::TransferrableModule is deprecated and will be removed in V8 v8.0. Replace all uses by CompiledWasmModule. Refs: v8#101 PR-URL: #30026 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WasmModuleObject::TransferrableModule is deprecated and will be removed
in V8 v8.0. Replace all uses by CompiledWasmModule.
make -j4 test(UNIX), orvcbuild test(Windows) passes