Skip to content

cksum: Bring back blake3 algorithm#11316

Draft
RenjiSann wants to merge 3 commits intouutils:mainfrom
RenjiSann:cksum-blake3
Draft

cksum: Bring back blake3 algorithm#11316
RenjiSann wants to merge 3 commits intouutils:mainfrom
RenjiSann:cksum-blake3

Conversation

@RenjiSann
Copy link
Collaborator

Fix #10002

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.

@oech3

This comment was marked as resolved.

@RenjiSann RenjiSann force-pushed the cksum-blake3 branch 3 times, most recently from 620f433 to b2d43e2 Compare March 13, 2026 16:10
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2026

Merging this PR will degrade performance by 99.88%

❌ 2 regressed benchmarks
✅ 298 untouched benchmarks
⏩ 46 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cksum_blake3 116.3 µs 93,223.6 µs -99.88%
Memory cksum_blake3 33.9 KB 43.5 KB -21.95%

Comparing RenjiSann:cksum-blake3 (3387ee5) with main (0f38c81)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Contributor

oech3 commented Mar 13, 2026

CodSpeed is invalid since it is based on a bunch of clap error.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

impl Default for Blake3 {
fn default() -> Self {
Self {
digest: Default::default(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
digest: Default::default(),
digest: blake3::Hasher::default(),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cksum: unknown algorithm: blake3: clap should have prevented this case

3 participants