feat(true/false): add benchmarks for startup performance#10996
feat(true/false): add benchmarks for startup performance#10996sylvestre merged 2 commits intouutils:mainfrom
Conversation
|
I think |
|
while someone might use |
425649c to
578c129
Compare
|
oke |
578c129 to
909f2b4
Compare
|
We want to sacrifice performance for cold |
Add benchmarks to evaluate true/false command performance, addressing GitHub issue uutils#10837. Benchmarks include: - Function call benchmarks (measure uumain directly) * true_no_args, true_help, true_version, true_consecutive_calls - Process spawn benchmarks (measure real command startup) * true_spawn_no_args, true_spawn_help, true_spawn_version This allows comparison between hot path vs cold path performance and internal logic vs real-world startup time.
909f2b4 to
50e5eea
Compare
|
oke, my changes satisfy that requirement |
|
🆕 20 new benchmarks I don't think we need 20 benchmarks for true & false |
|
Should we keep uumain bench only (considering we can't do anything for Rust's runtime itself)? |
|
yeah |
|
GNU testsuite comparison: |
Merging this PR will improve performance by 4.74%
Performance Changes
Comparing Footnotes
|
|
Is this OK to merge? Also I think RAM bench is not needed (not sure can we remove them or not...). |
|
I think true and false have some useless signal handling coming from |
Add benchmarks for true/false commands to measure startup performance. Includes both function call and process spawn benchmarks.
Closes #10837