Merged
Conversation
Deploying utcode-learn with
|
| Latest commit: |
ff86570
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07da577a.utcode-learn.pages.dev |
| Branch Preview URL: | https://update-samples.utcode-learn.pages.dev |
chvmvd
commented
Jul 13, 2025
| @@ -1,14 +1,14 @@ | |||
| <!doctype html> | |||
| <html lang="ja"> | |||
| <head> | |||
| <meta charset="utf-8" /> | |||
| <meta charset="UTF-8" /> | |||
Contributor
Author
There was a problem hiding this comment.
Viteがデフォルトで生成するファイルに合わせた形です。
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Vite App</title> | ||
| </head> | ||
| <body> | ||
| <div> | ||
| <canvas id="myChart"></canvas> | ||
| </div> | ||
| <script type="module" src="/main.js"></script> | ||
| <script type="module" src="/src/main.js"></script> |
Contributor
Author
There was a problem hiding this comment.
Viteがデフォルトで生成するファイルに合わせた形です。
| @@ -2,13 +2,16 @@ | |||
| "name": "chartjs", | |||
| "private": true, | |||
| "version": "0.0.0", | |||
| "type": "module", | |||
Contributor
Author
There was a problem hiding this comment.
Viteがデフォルトで生成するファイルに合わせた形です。
Comment on lines
+7
to
+9
| "dev": "vite", | ||
| "build": "vite build", | ||
| "preview": "vite preview" |
Contributor
Author
There was a problem hiding this comment.
Viteがデフォルトで生成するファイルに合わせた形です。
Contributor
Author
There was a problem hiding this comment.
Viteがデフォルトで生成するファイルから変更は加えていません。
Comment on lines
+8
to
+27
| "build": "tsc -b && vite build", | ||
| "lint": "eslint .", | ||
| "preview": "vite preview" | ||
| }, | ||
| "dependencies": { | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1" | ||
| "react": "^19.1.0", | ||
| "react-dom": "^19.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/react": "^18.3.3", | ||
| "@types/react-dom": "^18.3.0", | ||
| "@vitejs/plugin-react": "^4.3.1", | ||
| "typescript": "^5.5.4", | ||
| "vite": "^5.4.1" | ||
| "@eslint/js": "^9.30.1", | ||
| "@types/react": "^19.1.8", | ||
| "@types/react-dom": "^19.1.6", | ||
| "@vitejs/plugin-react": "^4.6.0", | ||
| "eslint": "^9.30.1", | ||
| "eslint-plugin-react-hooks": "^5.2.0", | ||
| "eslint-plugin-react-refresh": "^0.4.20", | ||
| "globals": "^16.3.0", | ||
| "typescript": "~5.8.3", | ||
| "typescript-eslint": "^8.35.1", | ||
| "vite": "^7.0.4" |
Contributor
Author
There was a problem hiding this comment.
Viteがデフォルトで生成するファイルから変更は加えていません。
Comment on lines
+1
to
9
| import { StrictMode } from "react"; | ||
| import { createRoot } from "react-dom/client"; | ||
| import App from "./App.tsx"; | ||
|
|
||
| ReactDOM.createRoot(document.getElementById("root") as HTMLElement).render( | ||
| <React.StrictMode> | ||
| createRoot(document.getElementById("root")!).render( | ||
| <StrictMode> | ||
| <App /> | ||
| </React.StrictMode>, | ||
| </StrictMode>, | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Viteがデフォルトで生成するファイルから変更は加えていません。
Contributor
Author
There was a problem hiding this comment.
Viteがデフォルトで生成するファイルから変更は加えていません。
chelproc
approved these changes
Jul 13, 2025
Contributor
chelproc
left a comment
chelproc
left a comment
There was a problem hiding this comment.
全部は見切れないですが多分大丈夫・・・？
サンプルプログラムのパッケージのメンテがしんどいので何か良き方法があるといいですね👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignoreで一部がnode_modulesなどになっていたため、/node_modulesの方に統一しました。（もともとは、/node_modulesに統一されていましたが、解答例を追加しました。 #63 の時に追加されたものがnode_modulesの表記になっていたことが主な原因と思われます。）