Skip to content

L10n feat/i18n#1738

Merged
elibosley merged 43 commits intofeat/i18nfrom
l10n_feat/i18n
Oct 3, 2025
Merged

L10n feat/i18n#1738
elibosley merged 43 commits intofeat/i18nfrom
l10n_feat/i18n

Conversation

@elibosley
Copy link
Member

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch l10n_feat/i18n

Comment @coderabbitai help to get the list of available commands and usage tips.

@elibosley elibosley merged commit 7583331 into feat/i18n Oct 3, 2025
1 check passed
@elibosley elibosley deleted the l10n_feat/i18n branch October 3, 2025 18:11
@claude
Copy link

claude bot commented Oct 3, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

"jsonforms.rclone.basic.showAdvanced.toggleDescription": "Afficher les options de configuration avancées.",
"jsonforms.rclone.validation.duration": "Format de durée invalide. Exemples : \"10s\", \"1.5m\", \"100ms\", \"1h15m\", \"off\".",
"jsonforms.rclone.validation.sizeSuffix": "Format de taille invalide. Exemples : \"10G\", \"100M\", \"1.5GiB\", \"off\".",
"logs.customFilterLabel": "Personnalisé {étiquette}",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve interpolation variable names in translations

The new locale strings rename the placeholders that the code passes to the i18n helper. For example, this entry uses {étiquette} instead of the original {label}. When t('logs.customFilterLabel', { label }) is called the value will no longer substitute, and the UI will render the literal token or an empty value. Similar placeholder renaming ({erreur}, {compte}, etc.) appears throughout these locale files, so every affected string will fail to interpolate at runtime.

Useful? React with 👍 / 👎.

elibosley added a commit that referenced this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant