Skip to content

fix(web): deploy dev script paths#1272

Closed
zackspear wants to merge 1 commit intomainfrom
fix/web-deploy-dev-script
Closed

fix(web): deploy dev script paths#1272
zackspear wants to merge 1 commit intomainfrom
fix/web-deploy-dev-script

Conversation

@zackspear
Copy link
Contributor

@zackspear zackspear commented Mar 25, 2025

Some recent changes in this script were targeting the wrong directory

Summary by CodeRabbit

  • Chores
    • Streamlined the deployment process to ensure consistency between file removal and synchronization.
    • Updated internal routines to better align component updates within a unified directory structure.

@zackspear zackspear requested review from pujitm and removed request for elibosley and mdatelle March 25, 2025 22:47
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2025

Walkthrough

The deployment script has been updated to modify directory paths used in SSH deletion, rsync synchronization, and the update_auth_request function. The changes remove the nuxt subdirectory from the targeted paths, replacing specific subdirectory deletions and destinations with broader commands using a wildcard. These adjustments ensure the deletion, synchronization, and path referencing are consistent with the new directory structure. No changes were made to exported or public entities.

Changes

File(s) Change Summary
web/scripts/deploy-dev.sh - Replaced nuxt/* in the SSH deletion command with * to clear the entire target directory.
- Adjusted the rsync command to sync files directly to the broader directory, removing the /nuxt subdirectory.
- Updated the WEB_COMPS_DIR in the update_auth_request function to reflect the new directory structure.

Sequence Diagram(s)

sequenceDiagram
    participant LS as Local Script
    participant RS as Remote Server

    LS->>RS: SSH command to delete files (using `*`) in .../dynamix.my.servers/unraid-components/
    RS-->>LS: Confirmation of deletion
    LS->>RS: Rsync command to sync updated files to .../dynamix.my.servers/unraid-components/
    RS-->>LS: Acknowledgment of synchronization
    LS->>LS: Update auth request referencing new WEB_COMPS_DIR path
Loading

Possibly related PRs

Suggested reviewers

  • pujitm
  • elibosley
  • mdatelle

Poem

In code's quiet realm, a change unfolds,
Paths realigned, new structure boldly holds.
The subdir removed with a sweeping star,
Sync and delete now blend near and far.
Cheers to clean code and stories retold!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 6636f65 and 1eb51c6.

📒 Files selected for processing (1)
  • web/scripts/deploy-dev.sh (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Build Web App
  • GitHub Check: Test API
  • GitHub Check: Build API
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (3)
web/scripts/deploy-dev.sh (3)

23-23: Updated Deletion Command: Broader Removal Scope
The deletion command now removes all items in /usr/local/emhttp/plugins/dynamix.my.servers/unraid-components/ instead of targeting a specific nuxt subdirectory. This aligns with the new directory structure, but please verify that this broader removal is intentional and won’t inadvertently delete files that should be retained.


25-25: Revised rsync Destination Path
The rsync_command now points to the updated target directory without the nuxt subdirectory. This change ensures consistency with the deletion command above. Just ensure that the source directory (.nuxt/nuxt-custom-elements/dist/unraid-components/) still contains the intended files for deployment.


40-40:

Details

❓ Verification inconclusive

Updated WEB_COMPS_DIR Path with Potential Regex Mismatch
The WEB_COMPS_DIR variable is correctly updated to remove the redundant nuxt subdirectory (now set to /usr/local/emhttp/plugins/dynamix.my.servers/unraid-components/_nuxt/). However, note that the subsequent regex in the inline awk (around line 60) still references the old /nuxt/_nuxt/ pattern. Please confirm if the regex should be updated to match the new directory structure or if this behavior is intentional.


Attention: Confirm AWK Regex Pattern Update
The WEB_COMPS_DIR variable is now updated to /usr/local/emhttp/plugins/dynamix.my.servers/unraid-components/_nuxt/, eliminating the redundant nuxt subdirectory. However, the inline AWK regex (around line 60) still references the old /nuxt/_nuxt/ pattern. Please verify if this discrepancy is intentional or if the regex should be adjusted to match the new directory structure.

  • File: web/scripts/deploy-dev.sh, Line ~60 (AWK regex)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zackspear zackspear requested a review from elibosley March 25, 2025 22:47
@github-actions
Copy link
Contributor

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1272/dynamix.unraid.net.plg

@zackspear zackspear closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant