Conversation
We should no longer be failing Label attributes for not having a "for" attribute, now that different methods of association are permitted.
- Allow 1.3.1's label association tests to be re-used. It now has a "mute errors" parameter and returns whether (and where) it's found its associations. - 4.1.2's label association test (for accessibility API) now re-uses this, if a label association is found in any way then it will not throw H91.
The test that flags "for" attributes on labels that don't point to a form control is now a warning, not an error. It is not a fail in itself (especially now explicit labels are not necessary), but often suggests a misused or typoed for attribute and thus should be manually checked. Also no error will appear if the "for" attribute is empty (for="").
Add an isDisabled method (triggering on disabled IDL attribute or aria-disabled="true") and use that to stop disabled elements (and their children) from being tested for contrast.
Conflicts: Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3_Contrast.js Standards/WCAG2AAA/Sniffs/Principle4/Guideline4_1/4_1_2.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.