Skip to content

Make Position.BaseSha nullable #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louis-z merged 1 commit into from
Apr 4, 2024
Merged

Make Position.BaseSha nullable #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NGitLab/Models/Position.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class Position
public LineRange LineRange { get; set; }

[JsonPropertyName("base_sha")]
public Sha1 BaseSha { get; set; }
public Sha1? BaseSha { get; set; }

[JsonPropertyName("head_sha")]
public Sha1 HeadSha { get; set; }
Expand Down
2 changes: 1 addition & 1 deletion NGitLab/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2773,7 +2773,7 @@ NGitLab.Models.PipelineVariable.PipelineVariable() -> void
NGitLab.Models.PipelineVariable.Value -> string
NGitLab.Models.PipelineVariable.VariableType -> string
NGitLab.Models.Position
NGitLab.Models.Position.BaseSha.get -> NGitLab.Sha1
NGitLab.Models.Position.BaseSha.get -> NGitLab.Sha1?
NGitLab.Models.Position.BaseSha.set -> void
NGitLab.Models.Position.HeadSha.get -> NGitLab.Sha1
NGitLab.Models.Position.HeadSha.set -> void
Expand Down